RFR [S]: 8227527: LogDecorations should lazily resolve host name

[Lois Foltan]

On 7/10/2019 10:56 AM, Claes Redestad wrote:
> Hi,
>
> reportedly the uname syscall taken to initialize logDecorations can
> carry a small but measurable startup cost on some systems/platforms, so
> the not-used-by-default _host_name should be lazily initialized.
>
> Webrev:  http://cr.openjdk.java.net/~redestad/8227527/open.00/
> Bug:     https://bugs.openjdk.java.net/browse/JDK-8227527
> Testing: t1-3
>
> Thanks!
>
> /Claes
Hi Claes,

This looks good.  One minor comment:

share/logging/logDecorations.cpp:
- line #53 - 55: I assume that if old_value is not equal to NULL implies 
that host_name and old_value should give you the same host name string, 
correct?
   You could always add an assert in the if statement if you think 
warranted, "assert(strcmp(old_value, host_name) != 0, "comment...");

Thanks,
Lois