RFR [S]: 8227527: LogDecorations should lazily resolve host name

[Thomas Stüfe]

Hi Claes,

On Thu, Jul 11, 2019, 14:45 Claes Redestad <claes.redestad at oracle.com>
wrote:

> Hi Thomas,
>
> On 2019-07-10 22:15, Thomas Stüfe wrote:
> > Hi Claes,
> >
> > This looks all very good.
>
> thanks,
>
> >
> > My only remark is not directed at your patch, but I would prefer
> > diagnostic code like logging not to crash at a native OOM (I refer to
> > the strdup), but rather handle it gracefully, e.g. by just printing
> > "???" as hostname.
>
> since this os::strdup_check_oom is used throughout the UL code, would
> you mind opening an RFE to have that evaluated more systematically? Or
> do you insist on a point fix here and now?
>
> Although highly unlikely, one could argue my patch here might defer the
> strdup to a point in time where the first ever logging attempted is in
> response to a native OOM situation, which might be making a crash ever
> so slightly more possible. While far-fetched, it is an argument for
> pre-emptively addressing this here an now.
>
> Thanks!
>
> /Claes
>


The patch is fine as it is. I will open a separate rfe for the oom issue.

Thanks, Thomas

>