[13] RFR(xs) 8227646: [TESTBUG] appcds/SharedArchiveConsistency timed out

[Calvin Cheung]

Dan,

Thanks for your review!

On 7/16/19 5:56 AM, Daniel D. Daugherty wrote:
> On 7/16/19 12:31 AM, Calvin Cheung wrote:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8227646
>>
>> webrev: http://cr.openjdk.java.net/~ccheung/8227646/webrev.00/
>
> test/hotspot/jtreg/runtime/appcds/SharedArchiveConsistency.java
>     Does the test intentionally crash in one or more of the test cases?
>     If not, then '-XX:-CreateCoredumpOnCrash' is not really needed.
>     I don't think '-XX:-CreateCoredumpOnCrash' will prevent the timeout
>     handling mechanism from trying to capture a core file in the case
>     of a timeout.
No, the test does not crash intentionally. Thanks for clarifying the 
-XX:-CreateCoredumpOnCrash. I will revert the change.
>
>     The test currently timed out with a default total timeout value of
>     480 seconds; that 480 comes from the default timeout value of 120
>     seconds and the default timeout factor of 4 (480 == 120 * 4).
>
>     The 'timeout=1000' value will get you a total timeout value of 4000.
>     I suspect that is not what you want.
>
>     If you specify 'timeout=240', you'll get a total timeout value of
>     960 seconds (240 * 4).

I've seen the total elapsed time for the test got very close to 960s. So 
to be on the safe side, I would set the timeout=300 as follows:

diff --git 
a/test/hotspot/jtreg/runtime/appcds/SharedArchiveConsistency.java 
b/test/hotspot/jtreg/runtime/appcds/SharedArchiveConsistency.java
--- a/test/hotspot/jtreg/runtime/appcds/SharedArchiveConsistency.java
+++ b/test/hotspot/jtreg/runtime/appcds/SharedArchiveConsistency.java
@@ -35,7 +35,7 @@
   * @build sun.hotspot.WhiteBox
   * @compile test-classes/Hello.java
   * @run driver ClassFileInstaller sun.hotspot.WhiteBox
- * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions 
-XX:+WhiteBoxAPI SharedArchiveConsistency
+ * @run main/othervm/timeout=300 -Xbootclasspath/a:. 
-XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI SharedArchiveConsistency
   */
  import jdk.test.lib.process.OutputAnalyzer;
  import jdk.test.lib.Utils;

I will do more testing with the above timeout before pushing the change.

Let me know if you'd like to see another webrev.

thanks,

Calvin

>
> Dan
>
>
>>
>> Increase the timeout to 1000s and add the -XX:-CreateCoredumpOnCrash 
>> option to disable coredump.
>>
>> Testing: on 2 macosx hosts on which the timeout was observed.
>>
>>
>> thanks,
>>
>> Calvin
>>
>