RFR (S): 8221205: Obsolete AllowJNIEnvProxy

[Harold Seigel]

Thanks for the explanation.

Harold

On 7/24/2019 8:47 AM, David Holmes wrote:
> Hi Harold,
>
> Thanks for taking a look at this.
>
> On 24/07/2019 9:55 pm, Harold Seigel wrote:
>> Hi David,
>>
>> This looks good.  Would it be worthwhile to add an assert that thread 
>> == JavaThread::current() in 
>> JavaThread::check_safepoint_and_suspend_for_native_trans(JavaThread 
>> *thread), or get rid of the thread parameter?
>
> That code is part of a much larger code sequence for thread-state 
> transitions that always operates on the current thread. So no assert 
> is needed just for this part. The thread parameter is needed in this 
> case because it is defined as a static method. It would be possible to 
> change it to an instance method, but that would require touching a lot 
> more code.
>
> Thanks,
> David
>
>> Thanks, Harold
>>
>> On 7/23/2019 7:49 PM, David Holmes wrote:
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8221205
>>> webrev: http://cr.openjdk.java.net/~dholmes/8221205/webrev/
>>>
>>> The ancient AllowJNIEnvProxy flag was deprecated in 13 and is now 
>>> being obsoleted in 14.
>>>
>>> The code that contained the flag check always operates on a thread 
>>> instance that is the current thread.
>>>
>>> Thanks,
>>> David