RFR (S): 8221205: Obsolete AllowJNIEnvProxy

[David Holmes]

On 24/07/2019 11:56 pm, Daniel D. Daugherty wrote:
> On 7/23/19 7:49 PM, David Holmes wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8221205
>> webrev: http://cr.openjdk.java.net/~dholmes/8221205/webrev/
> 
> src/hotspot/share/runtime/globals.hpp
>      No comments.
> 
> src/hotspot/share/runtime/thread.cpp
>      No comments.
> 
> Thumbs up.

Thanks for looking at this Dan!

>  > It would be possible to change it to an instance method, but that would
>  > require touching a lot more code.
> 
> I agree that getting rid of the 'thread' parameter and changing
> check_safepoint_and_suspend_for_native_trans() to an instance method
> does not have to be done by this fix. Do you want to log it as an RFE
> for the future or just move on to bigger fish?

Move on to bigger fish. This could be folded into a larger 
cleanup/change in this area - I suspect we still have a few in the pipeline.

Thanks,
David

> Dan
> 
> 
> 
> 
>>
>> The ancient AllowJNIEnvProxy flag was deprecated in 13 and is now 
>> being obsoleted in 14.
>>
>> The code that contained the flag check always operates on a thread 
>> instance that is the current thread.
>>
>> Thanks,
>> David
>