RFR(M): 8228743: [PPC64, s390] Implement FastJNIAccessors

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Tue Jul 30 12:29:08 UTC 2019


Hi Martin,

overall, the change looks good to me. 

It's a bit confusing that the method with the 
implementation has _int_ as infix:
generate_fast_get_int_field0
while it is used for all data types, 
but this is similar on other platforms. 

// order preceding load
You might want to capitalize this, like the other comments.
No webrev needed.

Best regards,
  Goetz.



> -----Original Message-----
> From: Doerr, Martin
> Sent: Montag, 29. Juli 2019 19:43
> To: hotspot-runtime-dev at openjdk.java.net; Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com>; Schmidt, Lutz <lutz.schmidt at sap.com>;
> Gustavo Romero <gromero at linux.vnet.ibm.com>
> Subject: RFR(M): 8228743: [PPC64, s390] Implement FastJNIAccessors
> 
> Hi,
> 
> 
> 
> I'd like to contribute fast JNI Get*Field platform implementations for PPC64
> and s390.
> 
> 
> 
> Please review:
> 
> http://cr.openjdk.java.net/~mdoerr/8228743_PPC64_s390_FastJNIAccessors/
> webrev.00/
> <http://cr.openjdk.java.net/~mdoerr/8228743_PPC64_s390_FastJNIAccessors
> /webrev.00/>
> 
> 
> 
> Best regards,
> 
> Martin
> 
> 



More information about the hotspot-runtime-dev mailing list