RFR (T) 8228673: Remove develop flag StrictSafepointChecks

[coleen.phillimore at oracle.com]

On 7/30/19 5:27 PM, coleen.phillimore at oracle.com wrote:
>
>
> On 7/30/19 5:12 PM, Aleksey Shipilev wrote:
>> On 7/30/19 10:43 PM, coleen.phillimore at oracle.com wrote:
>>> Remove option to turn off checking.  See bug for more details.
>>>
>>> open webrev at 
>>> http://cr.openjdk.java.net/~coleenp/2019/8228673.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8228673
>> Makes sense. Looks good.
>>
>> It is curious that there is #ifdef ASSERT block in 
>> Thread::check_for_valid_safepoint_state body,
>> which is probably redundant too, if we discount the idiosyncrasy 
>> between (not_)debug and (not_)product.
>>
> I think it needs it for rank(), which is not compiled in product. 
> #ifndef PRODUCT vs #ifdef ASSERT is a mess.
>
>     DEBUG_ONLY(if (rank() != Mutex::special) \
>                thread->check_for_valid_safepoint_state(false);)
>
> Thanks for the code review!
> Coleen

Oh, you mean this one in check_for_valid_safepoint_state (I answered too 
quickly on the first inconsistency).

#ifdef ASSERT
   if (potential_vm_operation && is_Java_thread()
       && !Universe::is_bootstrapping()) {

Maybe it's not redundant because of the optimized build.
Coleen