RFR (T) 8228673: Remove develop flag StrictSafepointChecks

[coleen.phillimore at oracle.com]

On 7/31/19 4:15 AM, Aleksey Shipilev wrote:
> On 7/30/19 11:31 PM, coleen.phillimore at oracle.com wrote:
>> Oh, you mean this one in check_for_valid_safepoint_state (I answered too quickly on the first
>> inconsistency).
>>
>> #ifdef ASSERT
>>    if (potential_vm_operation && is_Java_thread()
>>        && !Universe::is_bootstrapping()) {
>>
>> Maybe it's not redundant because of the optimized build.
> Yeah. I don't think we have to clean that up at the moment.

Not with this change.  We've talked about removing the optimized build, 
but there may still be users of it.  I'm surprised it built for me 
yesterday.

I have a change to this function later in my patch queue, so I'll clean 
this out with that change.  I'm trying to expand where we check NSV.

Thanks,
Coleen
>