RFR (S) 8228630: Remove always true parameter to NoSafepointVerifier

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Wed Jul 31 11:29:53 UTC 2019



On 7/30/19 6:31 PM, Kim Barrett wrote:
>> On Jul 30, 2019, at 5:33 PM, coleen.phillimore at oracle.com wrote:
>>
>>
>> I fixed the comment in thread.hpp above the _allow_safepoint_count and renamed the field to _no_safepoint_count, which makes a lot more sense.  Retesting.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/2019/8228630.02/webrev
> Thanks for renaming the member and updating the comment as we discussed.

Thanks Kim!
Coleen
>
> Looks good.
>
>> Thanks,
>> Coleen
>>
>> On 7/30/19 4:45 PM, coleen.phillimore at oracle.com wrote:
>>> Summary: Also remove NoGCVerifier since NoSafepointVerifier covers GC checking when not already at a safepoint and is a stronger check.
>>>
>>> See bug for more details also.  Tested with all jtreg runtime,compiler,serviceability and gc tests.  Also hs-tier1-3 on linux-x64-debug.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/2019/8228630.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8228630
>>>
>>> Thanks,
>>> Coleen
>



More information about the hotspot-runtime-dev mailing list