RFR(xxs): 8225178: [Solaris] os::signal() should call sigaction() with SA_SIGINFO

[Thomas Stüfe]

Thank you David.

On Tue, Jun 4, 2019 at 12:18 AM David Holmes <david.holmes at oracle.com>
wrote:

> Hi Thomas,
>
> On 3/06/2019 11:56 pm, Thomas Stüfe wrote:
> > Hi all,
> >
> > may I have reviews please for this small patch:
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8225178
> > webrev:
> >
> http://cr.openjdk.java.net/~stuefe/webrevs/8225178-solaris-sa_siginfo-missing/webrev.00/webrev/
>
> Looks good!
>
> > os::signal(), on Solaris, does not specify SA_SIGINFO. This leads to
> > signal handlers installed with this function - among others, the
> > secondary signal handler installed during error reporting - to be called
> > without siginfo_t pointer.
>
> Which is only a problem for the error reporting secondary handler, hence
> why we likely never noticed. :(
>
> Thanks,
> David
> -----
>
> > All other platforms specify SA_SIGINFO in os::signal(), and so does the
> > Solaris-specific code which installs the "big" primary signal handler.
> > At SAP we run with this fix (specifying SA_SIGINFO) since years.
> >
> > Thanks, Thomas
>