RFR(T) 8224497: Remove FIXME in metaspaceClosure.cpp

[Calvin Cheung]

Hi Jiangli,

I'll change the '5' to '4' before pushing the change.

Thanks for your review.

Calvin

On 6/7/19, 1:17 PM, Jiangli Zhou wrote:
> Hi Calvin,
>
> The removal of the FIXME looks ok.
>
> - src/hotspot/share/memory/metaspaceShared.cpp
>
>   // The s0/s1 and oa0/oa1 regions are populated inside
> HeapShared::archive_java_heap_objects.
>   // Their layout is independent of the other 5 regions.
>
> '5 regions' also needs updating. My original opinion about JDK-8218751
> remain unchanged.
>
> Regards,
> Jiangli
>
>
> On Fri, Jun 7, 2019 at 11:47 AM Calvin Cheung<calvin.cheung at oracle.com>  wrote:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8224497
>>
>> webrev: http://cr.openjdk.java.net/~ccheung/8224497/webrev.00/
>>
>> A trivial fix to remove a leftover FIXME during the development of
>> dynamic CDS archive.
>>
>> I also take this opportunity to remove the comment and an unused
>> function regarding the od (optional data) region.
>> The region was removed after the fix for JDK-8218751.
>>
>> Testing: ran all AppCDS tests locally on linux-x64;
>>                running tiers1-3 testing using mach5.
>>
>> thanks,
>> Calvin