RFR(S): 8223249: [s390] Cleanup TemplateInterpreterGenerator::generate_fixed_frame

[Gustavo Romero]

Hi Martin,

Change looks good!

Just some nits:

Besides the change in
-  // Tirst check the for the interpreter frame's magic.
+  // First check the for the interpreter frame's magic.

to something like:

   // First check for the interpreter frame's magic.

1143   // Load cp cache and save it at the and of this block.
s/and/end/

and in
1138   // Save sender SP from F1 (i.e. before it was potentially modified by an
1139   // adapter) into F0's interpreter state. We us it as well to revert
1140   // resizing the frame above.

s/us/use/

You can fix them before pushing only, no new webrev needed.

Best regards,
Gustavo

On 05/15/2019 01:02 PM, Doerr, Martin wrote:
> Hi Coleen,
> 
>> This looks better because it's nice when all the platforms have the same
>> function names.
> Definitely, yes.
> 
>> I can't really review the s390 code but seems plausible anyway.
> I'll wait for s390 experts to find some time. Thank you for taking a look and helping to improve it.
> 
> Best regards,
> Martin
>