RFR: 8225788: Dead code in thread and safepoint
David Holmes
david.holmes at oracle.com
Fri Jun 14 13:08:04 UTC 2019
Hi Robbin,
Sending out three RFRs after 6pm on my Friday night is not fair! I will
look at them all but not in detail till Monday :)
This one was much larger than expected. Some surprises hiding in there
:) There are a couple of things where my initial reaction is "hang on!"
so I need to look at a couple of things more closely. :)
E.g isn't JavaThread::trace_oops useful from the debugger?
It also seems to me that there is further dead code based on some of
your changes E.g. I don't see _orig_thread_state actually being read by
anything.
Cheers,
David
On 14/06/2019 10:29 pm, Robbin Ehn wrote:
> Hi all, please review.
>
> Removing some dead code.
>
> Code:
> http://cr.openjdk.java.net/~rehn/8225788/webrev/index.html
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8225788
>
> Thanks, Robbin
More information about the hotspot-runtime-dev
mailing list