RFR: 8225788: Dead code in thread and safepoint

[Robbin Ehn]

Hi Dan,

On 2019-06-18 18:34, Daniel D. Daugherty wrote:
> src/hotspot/share/runtime/thread.cpp
>      Same question as David H. about the usefulness of calling
>      JavaThread::trace_oops() from the debugger. I think that Coleen
>      and Lois do the most bad oop hunting on the Runtime team

Should be easily sorted out next week if not sooner.

> 
> src/hotspot/share/runtime/vmOperations.hpp
>      Hmmm... I wonder if the calling thread's priority is useful
>      for debugging safepoint starvation issues. David H. has been
>      in the thread priority code previously...
> 
> src/hotspot/share/runtime/vmOperations.cpp
>      No comments.
> 
> src/hotspot/share/compiler/compileBroker.cpp
>      Ummmm... So you're deleting the code that is recording when
>      a JavaThread is blocked on compilation. Of course, that
>      makes the setter and the field dead, but you made it that
>      way. I don't see any explanation in the bug report or in
>      the code review request explaining why it is no longer
>      useful to record this info.
> 
>      This might be useful state information when debugging.

This information is only available in a debugger, and in a debugger you can just
do stack trace for the thread in question. If it is useful I argue it should be
hs_err.

> 
> src/hotspot/share/runtime/vframe_hp.cpp
>      No comments.
> 
> src/hotspot/share/runtime/vmThread.cpp
>      No comments.
> 
> Thumbs up! However, other folks might have different opinions
> about some of the stuff you are deleting.

Yes, let's see what people think!

Thanks again!

/Robbin

> 
> Dan
> 
> 
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8225788
>>
>> Thanks, Robbin
>