RFR (S) 8214822: Move ConcurrentHashTable VALUE parameter to CONFIG
David Holmes
david.holmes at oracle.com
Fri Jun 21 01:29:51 UTC 2019
Hi Coleen,
On 20/06/2019 10:39 am, coleen.phillimore at oracle.com wrote:
> Summary: make VALUE parameter be included in CONFIG configuration, also
> remove BaseConfig
>
> Tested with tier1-3.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/2019/8214822.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8214822
I don't understand all the "value" typedef's you have introduced:
+ typedef WeakHandle<vm_string_table_data> value;
+ typedef Symbol* value; // value of the Node in the hashtable
+ typedef WeakHandle<vm_resolved_method_table_data> value;
If "value" is meant to be a type then it should be "Value", as "value"
is used as the variable name everywhere. But I don't see you actually
using the typedefs anywhere ??
Thanks,
David
-----
> Thanks,
> Coleen
More information about the hotspot-runtime-dev
mailing list