RFR (S) 8214822: Move ConcurrentHashTable VALUE parameter to CONFIG

Kim Barrett kim.barrett at oracle.com
Sun Jun 23 17:17:39 UTC 2019


> On Jun 21, 2019, at 10:28 AM, coleen.phillimore at oracle.com wrote:
> 
> On 6/21/19 10:12 AM, David Holmes wrote:
>> Second now that you have the typedef why aren't you using it in the function declaration ie.
>> 
>> static uintx get_hash(Value const& value, bool* is_dead) {
>> 
> 
> I could change this too.

For the record, doing that was intended to be part of this RFE.  (I can say that definitively :)

"The CONFIG type must contain references to a type that must match the VALUE type.
It would be better to have the CONFIG type be the source of that information, via a public typedef, …”

That is, rather than having references to a type that must match the external VALUE type, use the typedef type.

I’m currently working on a review of the latest version.



More information about the hotspot-runtime-dev mailing list