RFR: 8220566: AArch64: Set default vm features for Ampere eMAG CPUs
Andrew Dinn
adinn at redhat.com
Wed Mar 13 10:26:38 UTC 2019
Hi Patrick,
On 13/03/2019 10:11, Patrick Zhang OS wrote:
> Please help review this patch for setting default vm features specifically for Ampere eMAG CPUs.
>
> Webrev: http://cr.openjdk.java.net/~qpzhang/8220566/webrev.01
> JBS: https://bugs.openjdk.java.net/browse/JDK-8220566
>
> Tested with Ampere eMAG platforms, jtreg jdk_core and jcstress, etc.
The patch looks like it might be ok. However, that's hard to say because
the JIRA issue simply restates what is in the patch i.e. that these
specific code changes are needed.
Could you add a note on the JIRA issue explaining why these
configuration options are preferred? At that point it will be possible
to review the patch.
regards,
Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
More information about the hotspot-runtime-dev
mailing list