RFR: 8220366: Optimize Symbol handling in ClassVerifier and SignatureStream

Harold Seigel harold.seigel at oracle.com
Thu Mar 14 15:57:46 UTC 2019


Hi Claes,

The updated webrev looks good.

Thanks, Harold

On 3/13/2019 7:05 PM, Claes Redestad wrote:
> Hi Harold,
>
> thanks for reviewing!
>
> On 2019-03-13 19:02, Harold Seigel wrote:
>> Hi Claes,
>>
>> Could you change the first ClassVerifier::create_temporary_symbol() 
>> function to just extract the name and length and then call the other 
>> one?
>>
>> Also, can you move the setting of 'len' in Symbol::make_permanent() 
>> to just before calling cmpxchg() ?
>
> Sure:
>
> http://cr.openjdk.java.net/~redestad/8220366/open.01
>
> Passed tier1+2
>
> /Claes


More information about the hotspot-runtime-dev mailing list