RFR: 8221221: [testbug] make test TEST="jtreg:test/hotspot/jtreg/runtime/containers" failed on Ubuntu 18.04

[Jie Fu]

Good suggestions!

Thanks Severin.


On 2019/3/21 下午4:57, Severin Gehwolf wrote:
> Hi,
>
> On Thu, 2019-03-21 at 16:23 +0800, Jie Fu wrote:
>> Hi all,
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8221221
>>
>> make test TEST="jtreg:test/hotspot/jtreg/runtime/containers" failed on
>> Ubuntu 18.04.
>>
>> The issue can be fixed by
>> -----------------------------------------------
>> diff -r ce78fac1f6d5
>> test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest
>> --- a/test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest
>> Thu Mar 21 01:49:27 2019 +0100
>> +++ b/test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest
>> Thu Mar 21 15:44:39 2019 +0800
>> @@ -1,4 +1,4 @@
>> -FROM oraclelinux:7.6
>> +FROM fedora:29
>>    MAINTAINER mikhailo.seledtsov at oracle.com
>>
>>    COPY /jdk /jdk
>> -----------------------------------------------
>>
>> The change has been tested with
>> -----------------------------------------------
>> make test TEST="test/jdk/jdk/modules/scenarios/container
>> test/hotspot/jtreg/vmTestbase/vm/gc/containers
>> test/hotspot/jtreg/runtime/containers"
>> -----------------------------------------------
>> on Linux/x86-64 (Ubuntu 18.04).
>>
>> Could you please review it?
>> Thanks a lot.
>>
>> Best regards,
>> Jie
> This fix will be inadequate as the expectation is to have the
> (reasonably?) same base image as the build platform. If you had built
> the JDK on say, centos 7, then the test would likely work.
>
> So if anything, I agree with David who commented on the bug, there
> should be a way to set the to-be-used base image via some option in the
> test using the current value as a default.
>
> Here is what AdoptOpenJDK does:
>
> ARG IMAGE_NAME=adoptopenjdk/openjdk8
> ARG IMAGE_VERSION=latest
>
> FROM $IMAGE_NAME:$IMAGE_VERSION
>
> Example usage:
> docker build --build-arg IMAGE_NAME=fedora --build-arg IMAGE_VERSION=29 [...]
>
> Thanks,
> Severin
>