RFR(S): 8221342: [TESTBUG] Generate Dockerfile for docker testing

[David Holmes]

Hi Jie,

On 25/03/2019 11:57 am, Jie Fu wrote:
> Hi Misha,
> 
> I had tested this patch on Ubuntu 18.04 (x64) with make test 
> TEST="test/hotspot/jtreg/runtime/containers/docker".
> But it still failed with the same reason.
> 
> Am I lost something?

Did you define properties for the custom image name and version? (I have 
no idea how to pass properties to jtreg via the "make" invocation.)

David
-----

> Thanks.
> 
> Best regards,
> Jie
> 
> On 2019/3/23 上午9:07, mikhailo.seledtsov at oracle.com wrote:
>> Please review this improvement to docker/container related testing in 
>> HotSpot and JDK.
>> This change came out of discussion for "8221221 make test 
>> TEST="jtreg:test/hotspot/jtreg/runtime/containers" failed on Ubuntu 
>> 18.04". This fix is more generic, allowing to specify 
>> platform-specific docker base images, as well custom base images 
>> specified via test properties at test execution time. Also, it 
>> eliminates duplication (duplicate Dockerfile-xyz).
>>
>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8221342
>>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8221342.01/
>>     Testing:
>>       rm -Rf JT*; jtreg -v1 
>> test/hotspot/jtreg/runtime/containers/docker/ 
>> jdk/jdk/internal/platform/docker/
>>       All PASS
>>
>>       rm -Rf JT*; jtreg -v1 -Djdk.test.docker.image.name=ubuntu \
>>           -Djdk.test.docker.image.version=latest\
>>            test/hotspot/jtreg/runtime/containers/docker/ 
>> jdk/jdk/internal/platform/docker/
>>       All PASS
>>       Also ran the image interactively to make sure it is based on ubuntu
>>
>>
>> Thank you,
>>
>> Misha
>>
>