RFR(S): 8221342: [TESTBUG] Generate Dockerfile for docker testing

[mikhailo.seledtsov at oracle.com]

David, Thank you for review.


Thank you,

Misha



On 3/24/19 6:49 PM, David Holmes wrote:
> Hi Misha,
>
> I don't know the details of Dockerfiles but in terms of generating 
> something to replace the existing physical files, this looks fine.
>
> Thanks,
> David
>
> On 23/03/2019 11:07 am, mikhailo.seledtsov at oracle.com wrote:
>> Please review this improvement to docker/container related testing in 
>> HotSpot and JDK.
>> This change came out of discussion for "8221221 make test 
>> TEST="jtreg:test/hotspot/jtreg/runtime/containers" failed on Ubuntu 
>> 18.04". This fix is more generic, allowing to specify 
>> platform-specific docker base images, as well custom base images 
>> specified via test properties at test execution time. Also, it 
>> eliminates duplication (duplicate Dockerfile-xyz).
>>
>>      JBS: https://bugs.openjdk.java.net/browse/JDK-8221342
>>      Webrev: http://cr.openjdk.java.net/~mseledtsov/8221342.01/
>>      Testing:
>>        rm -Rf JT*; jtreg -v1 
>> test/hotspot/jtreg/runtime/containers/docker/ 
>> jdk/jdk/internal/platform/docker/
>>        All PASS
>>
>>        rm -Rf JT*; jtreg -v1 -Djdk.test.docker.image.name=ubuntu \
>>            -Djdk.test.docker.image.version=latest\
>>             test/hotspot/jtreg/runtime/containers/docker/ 
>> jdk/jdk/internal/platform/docker/
>>        All PASS
>>        Also ran the image interactively to make sure it is based on 
>> ubuntu
>>
>>
>> Thank you,
>>
>> Misha
>>