RFR(S): 8221342: [TESTBUG] Generate Dockerfile for docker testing

[Jie Fu]

Hi Misha,

Thanks for your nice work.

Could you please also add this comment in DockerfileConfig.java?
----------------------------------------------------------------
make test TEST="test/hotspot/jtreg/runtime/containers/docker" 
JTREG="JAVA_OPTIONS=-Djdk.test.docker.image.name=ubuntu 
-Djdk.test.docker.image.version=latest"
----------------------------------------------------------------
It works for running these tests via make.

I still think it is important to update the jdk/doc/testing.md for 
docker tests.
If you are too busy to do that, we (Loongson) would like to do that.

Thanks a lot.

Best regards,
Jie


On 2019/3/25 下午11:19, mikhailo.seledtsov at oracle.com wrote:
> Hi Jie,
>
>   Sorry I did not mention in the email how to specify the custom 
> docker image name and version.
>
> Here is how to use it to specify custom docker version:
>
>   jtreg -Djdk.test.docker.image.name=ubuntu 
> -Djdk.test.docker.image.version=latest 
> test/hotspot/jtreg/runtime/containers/docker/
>
>
> Using test properties in this way is a common technique with JTreg 
> testing.
>
>
> Thank you,
>
> Misha
>
> On 3/24/19 7:20 PM, Jie Fu wrote:
>> Hi David,
>>
>> No, I didn't specify the custom image name and version.
>> I had just assumed that it can be dynamically and automatically 
>> generated  based on my test environment.
>>
>> So I think it might be better to update the jdk/doc/testing.md for 
>> the docker tests.
>>
>> Best regards,
>> Jie
>>
>> On 2019/3/25 上午10:04, David Holmes wrote:
>>> Hi Jie,
>>>
>>> On 25/03/2019 11:57 am, Jie Fu wrote:
>>>> Hi Misha,
>>>>
>>>> I had tested this patch on Ubuntu 18.04 (x64) with make test 
>>>> TEST="test/hotspot/jtreg/runtime/containers/docker".
>>>> But it still failed with the same reason.
>>>>
>>>> Am I lost something?
>>>
>>> Did you define properties for the custom image name and version? (I 
>>> have no idea how to pass properties to jtreg via the "make" 
>>> invocation.)
>>>
>>> David
>>> -----
>>>
>>>> Thanks.
>>>>
>>>> Best regards,
>>>> Jie
>>>>
>>>> On 2019/3/23 上午9:07, mikhailo.seledtsov at oracle.com wrote:
>>>>> Please review this improvement to docker/container related testing 
>>>>> in HotSpot and JDK.
>>>>> This change came out of discussion for "8221221 make test 
>>>>> TEST="jtreg:test/hotspot/jtreg/runtime/containers" failed on 
>>>>> Ubuntu 18.04". This fix is more generic, allowing to specify 
>>>>> platform-specific docker base images, as well custom base images 
>>>>> specified via test properties at test execution time. Also, it 
>>>>> eliminates duplication (duplicate Dockerfile-xyz).
>>>>>
>>>>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8221342
>>>>>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8221342.01/
>>>>>     Testing:
>>>>>       rm -Rf JT*; jtreg -v1 
>>>>> test/hotspot/jtreg/runtime/containers/docker/ 
>>>>> jdk/jdk/internal/platform/docker/
>>>>>       All PASS
>>>>>
>>>>>       rm -Rf JT*; jtreg -v1 -Djdk.test.docker.image.name=ubuntu \
>>>>>           -Djdk.test.docker.image.version=latest\
>>>>>            test/hotspot/jtreg/runtime/containers/docker/ 
>>>>> jdk/jdk/internal/platform/docker/
>>>>>       All PASS
>>>>>       Also ran the image interactively to make sure it is based on 
>>>>> ubuntu
>>>>>
>>>>>
>>>>> Thank you,
>>>>>
>>>>> Misha
>>>>>
>>>>
>>
>