RFR(xs): 8220786: Create new switch to redirect error reporting output to stdout or stderr

[David Holmes]

Hi Thomas,

Sorry a couple more typos in the test messages:

  67         throw new RuntimeException("Expection mention of hs-err 
file but none found.");

s/Expection/Expected/

75         System.out.println("No mentioning an hs-err file - ok! ");

s/mentioning/mention of/

No need to see updated webrev.

Thanks,
David

On 26/03/2019 6:22 pm, Thomas Stüfe wrote:
> Hi David,
> 
> thanks for the review.
> 
> New Webrev: 
> http://cr.openjdk.java.net/~stuefe/webrevs/8220786--create-new-switch-to-redirect-error-reporting-output-to-stdout-or-stderr/webrev.01/webrev/index.html
> 
> Remarks inline:
> 
> On Tue, Mar 26, 2019 at 8:10 AM David Holmes <david.holmes at oracle.com 
> <mailto:david.holmes at oracle.com>> wrote:
> 
>     Hi Thomas,
> 
>     Thanks for your patience on this one re the CSR discussions.
> 
> 
> No problem, was not that bad.
> 
>     On 25/03/2019 6:39 pm, Thomas Stüfe wrote:
>      > May I please have reviews for this addition:
>      >
>      > cr:
>      >
>     http://cr.openjdk.java.net/~stuefe/webrevs/8220786--create-new-switch-to-redirect-error-reporting-output-to-stdout-or-stderr/webrev.00/webrev/
>      > issue: https://bugs.openjdk.java.net/browse/JDK-8220786
>      > csr: https://bugs.openjdk.java.net/browse/JDK-8220787
>      >
>      > This implements the new switches -XX:ErrorFileToStdout/ToStderr. For
>      > details please see the associated CSR and this mailthread:
>      >
>      >
>     https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2019-March/033160.html
> 
>     Changes look fine to me. One query in vmError.cpp:
> 
>     1490     if (fd_log != -1) {
>     1491       close(fd_log);
>     1492       fd_log = -1;
>     1493     }
> 
>     Do we need to skip the above if using stdout/err ?
> 
> 
> Good catch. Fixed.
> 
>     And in the test:
> 
>        2  * Copyright (c) 2013, 2019, Oracle and/or its affiliates. All
>     rights reserved.
> 
>     2013 ??
> 
> 
> Stupid copy paste error. Fixed.
> 
> 
>     67         throw new RuntimeException("Expection mention of hs-err file
>     but none fount.");
> 
>     Typo: fount -> found
> 
> 
> Fixed.
> 
>      > Note that I am not sure yet about the CSR state. It has two
>     reviewers, one
>      > of them part of the CSR group. But it is still in proposed state.
> 
>     CSR reviews are distinct from CSR approval. Joe Darcy will approve the
>     CSR once he gets to it. Then you can push (assuming RFR completed).
> 
> 
> Okay, thank you.
> 
> Cheers, Thomas
> 
>     Thanks,
>     David
> 
> 
>      > Cheers, Thomas
>      >
>