RFR(T): 8221527: [TESTBUG] DockerBasicTest.java contains hard-coded reference to JDK 10

mikhailo.seledtsov at oracle.com mikhailo.seledtsov at oracle.com
Wed Mar 27 02:55:48 UTC 2019


Hi David,

  Thank you for review.


On 3/26/19 7:16 PM, David Holmes wrote:
> Hi Misha,
>
> On 27/03/2019 10:23 am, mikhailo.seledtsov at oracle.com wrote:
>> Please review this simple/trivial change that removes hard-coded 
>> reference to JDK 10 in the image name,
>> and uses docker test library method instead.
>>
>>      JBS: https://bugs.openjdk.java.net/browse/JDK-8221527
>>      Webrev: http://cr.openjdk.java.net/~mseledtsov/8221527.00/
>>      Testing:
>>         Ran the affected test
>
> Change seems fine.
>
> I'm confused by the fact this seems not to have caused any testing 
> issues. Have we been using the wrong image during testing? Or was the 
> image simply mis-named?
The image was simply misnamed. The content of the Docker image was/is 
the current JDK under test.


Thank you,
Misha
>
> Thanks,
> David
>
>> Thank you,
>> Misha
>>
>>
>>
>>



More information about the hotspot-runtime-dev mailing list