RFR: JDK-8221596: test/hotspot/jtreg/runtime/containers/docker/TestCPUSets.java failed with FileAlreadyExistsException

[David Holmes]

Hi Jie,

On 28/03/2019 4:21 pm, Jie Fu wrote:
> Hi all,
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8221596
> 
> For more info (e.g. the symptom & how to reproduce), please see the JBS.
> 
> It can be fixed by
> -----------------------------------------
> diff -r 55025f677f68 test/lib/jdk/test/lib/containers/docker/Common.java
> --- a/test/lib/jdk/test/lib/containers/docker/Common.java Thu Mar 28 
> 04:30:52 2019 +0000
> +++ b/test/lib/jdk/test/lib/containers/docker/Common.java Thu Mar 28 
> 14:00:09 2019 +0800
> @@ -1,5 +1,5 @@
>   /*
> - * Copyright (c) 2017, 2018, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights 
> reserved.
>    * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>    *
>    * This code is free software; you can redistribute it and/or modify it
> @@ -30,6 +30,7 @@
>   import java.io.File;
>   import java.nio.file.Files;
>   import java.nio.file.Paths;
> +import java.nio.file.StandardCopyOption;
>   import jdk.test.lib.containers.docker.DockerRunOptions;
>   import jdk.test.lib.containers.docker.DockerTestUtils;
>   import jdk.test.lib.Utils;
> @@ -46,7 +47,7 @@
> 
>       public static void prepareWhiteBox() throws Exception {
>           Files.copy(Paths.get(new File("whitebox.jar").getAbsolutePath()),
> -                   Paths.get(Utils.TEST_CLASSES, "whitebox.jar"));
> +                   Paths.get(Utils.TEST_CLASSES, "whitebox.jar"), 
> StandardCopyOption.REPLACE_EXISTING);
>       }

Normally to use WhiteBox a test specifies:

  @run driver ClassFileInstaller sun.hotspot.WhiteBox

Is there a reason this test can't use that?

Thanks,
David
-----

> 
> -----------------------------------------
> 
> Could you please review it?
> Thanks a lot.
> 
> Best regards,
> Jie
> 
>