Ping.. RFR(T): 8221480: jcmd VM.metaspace shall print limits in basic mode

[Thomas Stüfe]

Hi Robbin, Andrew,

thanks for reviewing!

New version:

See:
http://cr.openjdk.java.net/~stuefe/webrevs/8221480--jcmd-vm.metaspace-shall-print-limits-in-basic-mode-too/webrev.02/webrev/

The patch is the same, but I added a check for the new output in the
associated jtreg test.

Cheers, Thomas



On Fri, Mar 29, 2019 at 12:17 PM Andrew Dinn <adinn at redhat.com> wrote:

> On 29/03/2019 09:01, Thomas Stüfe wrote:
> > Polite Ping...
> >
> > Guys, this is really trivial. I factor out things like this from bigger
> > changes to make them easier to review.
> >
> > New version:
> >
> http://cr.openjdk.java.net/~stuefe/webrevs/8221480--jcmd-vm.metaspace-shall-print-limits-in-basic-mode-too/webrev.01/webrev/
> Ah, I was going to ask why the two different comparisons for printing
> unlimited then I saw you fixed this in the 2nd version.
>
> Looks good.
>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
>