RFR 8221698 Remove redundant includes from popular header files

Ioi Lam ioi.lam at oracle.com
Fri Mar 29 18:42:37 UTC 2019


Hi Coleen, thanks for the review. I've removed the things you mentioned.

- Ioi

On 3/29/19 11:10 AM, coleen.phillimore at oracle.com wrote:
>
> Hey Ioi, while you're here, can you remove SuperTypeClosure from 
> instanceKlass.hpp.
>
> And don't forget to remove the commented out:
>
> +//#include "classfile/moduleEntry.hpp"
> +//#include "classfile/packageEntry.hpp"
>
> Looks good! Thank you for cleaning up the include files more.
>
> Coleen
>
> On 3/29/19 12:33 PM, Ioi Lam wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8221698
>> http://cr.openjdk.java.net/~iklam/jdk13/8221698-remove-redundant-includes.v01/ 
>>
>>
>> The following files are included by some popular header files. This 
>> causes them to be included by almost all HotSpot C files. However, 
>> these header are for features that are not commonly used. Excluding 
>> them can improve HotSpot build speed by 1~2%.
>>
>>   histogram.hpp
>>   classLoader.hpp
>>   utf8.hpp
>>   moduleEntry.hpp
>>   packageEntry.hpp
>>
>> Thanks
>> - Ioi
>



More information about the hotspot-runtime-dev mailing list