RFR (T) 8223190: Test gc/arguments/TestShrinkHeapInSteps.java breaks with change for JDK-8074355

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Wed May 1 15:40:17 UTC 2019



On 5/1/19 11:31 AM, Daniel D. Daugherty wrote:
> On 5/1/19 11:25 AM, coleen.phillimore at oracle.com wrote:
>> Summary: Remove too strict assert.
>>
>> See bug for details.  David didn't like this assert.
>>
>> Built and tested locally.
>>
>> open webrev at 
>> http://cr.openjdk.java.net/~coleenp/2019/8223190.01/webrev
>
> src/hotspot/share/runtime/mutex.cpp
>     Hmmm... do you plan on restoring the assert() once all the CMS
>     locking params are cleaned up?

Thanks for reviewing this.  I'd like to restore the assert but I'll run 
more rigorous testing first.   It might be better to have typed locks as 
Robbin suggested in the thread, so that we'd get a compilation error for 
mismatched safepoint checking lock calls.

Coleen

>
> Thumbs up!
>
> Dan
>
>
>
>> bug link https://bugs.openjdk.java.net/browse/JDK-8223190
>>
>> Thanks to Harold for the failure alert!
>> Coleen
>



More information about the hotspot-runtime-dev mailing list