RFR(S): 8222769: [TESTBUG] TestJFRNetworkEvents should not rely on hostname command
Erik Gahlin
erik.gahlin at oracle.com
Wed May 1 20:00:03 UTC 2019
Looks good.
An alternative to avoid the matchFound variable is to move the check
into a separate method, for example assertLocalAddress(String) and
return if a match is found. That said, I'm fine it as is.
Thanks
Erik
> Here is the updated webrev:
> http://cr.openjdk.java.net/~mseledtsov/8222769.01/
>
>
> On 4/25/19 6:38 PM, mikhailo.seledtsov at oracle.com wrote:
>> Thank you Leonid,
>>
>>
>> On 4/25/19 6:25 PM, Leonid Mesnik wrote:
>>> Hi
>>>
>>> The overall fix looks food. But I expect that there are might be
>>> different docker environments.
>>> Would not be more robust to verify that address exist in
>>> getLocalIp() list and fails if not?
>> Sounds good. I will update the code to match the address reported by
>> JFR to all the addresses returned by getLocalIp(). If at least a
>> single match found, test continues. If not, test fails.
>>
>> Misha
>>>
>>> Leonid
>>>
>>>> On Apr 25, 2019, at 5:51 PM, mikhailo.seledtsov at oracle.com wrote:
>>>>
>>>> Please review this change that uses a better platform independent
>>>> way of obtaining IP address inside a docker container.
>>>> This test worked for Oracle Linux, but did not work on Fedora,
>>>> which is now fixed.
>>>> The code for obtaining IP address in getLocalIp() was contributed
>>>> by Severin, thank you Severin.
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8222769
>>>> Webrev: http://cr.openjdk.java.net/~mseledtsov/8222769.00/
>>>> Testing:
>>>> Ran the affected test on Linux-x64 (Oracle Linux 7.3, 7.6)
>>>> - Passed
>>>>
>>>>
>>>> Thank you,
>>>> Misha
>>>>
>>
>
More information about the hotspot-runtime-dev
mailing list