RFR(XS): 8223248: [AIX] Remove old xlC 10 workaround for load acquire

Doerr, Martin martin.doerr at sap.com
Fri May 3 14:28:41 UTC 2019


Hi Götz and Lutz,

thank you for the reviews. I'll push it without the old comment.

Best regards,
Martin


-----Original Message-----
From: Lindenmaier, Goetz 
Sent: Freitag, 3. Mai 2019 16:26
To: Doerr, Martin <martin.doerr at sap.com>; hotspot-runtime-dev at openjdk.java.net
Subject: RE: RFR(XS): 8223248: [AIX] Remove old xlC 10 workaround for load acquire

Hi Martin, 

the fix looks good. 
I would remove the old comment altogether.
Don't need to see a new webrev.

Best regards,
  Goetz.

> -----Original Message-----
> From: hotspot-runtime-dev <hotspot-runtime-dev-bounces at openjdk.java.net>
> On Behalf Of Doerr, Martin
> Sent: Donnerstag, 2. Mai 2019 17:38
> To: hotspot-runtime-dev at openjdk.java.net
> Subject: [CAUTION] RFR(XS): 8223248: [AIX] Remove old xlC 10 workaround for
> load acquire
> 
> Hi,
> 
> the load acquire implementation in orderAccess_aix_ppc.hpp still contains a
> workaround from the time in which we were using xlC 10.1:
> We use lwsync instead of twi+isync which is used on linux.
> This compiler is no longer supported and the VM has been tested with
> xlClang++ 16.1 (JDK13) without the workaround.
> (Already JDK8-12 require at least xlC 12.01. Also see
> https://wiki.openjdk.java.net/display/Build/Supported+Build+Platforms)
> 
> I'd like AIX to use the same implementation as linux. Please review:
> http://cr.openjdk.java.net/~mdoerr/8223248_remove_XLC10_workaround/we
> brev.00/
> 
> Best regards,
> Martin



More information about the hotspot-runtime-dev mailing list