RFR (T) 8223412: tier1 build failure after 8222893

[coleen.phillimore at oracle.com]

No retract this.  WizardMode is settable in PRODUCT.  Happy Monday.
Coleen

On 5/6/19 6:01 PM, coleen.phillimore at oracle.com wrote:
> Vladimir (kvn) tells me that #ifndef PRODUCT isn't right for optimized 
> builds, so I've changed this to #ifdef ASSERT instead:
>
> diff --git a/test/hotspot/gtest/oops/test_markOop.cpp 
> b/test/hotspot/gtest/oops/test_markOop.cpp
> --- a/test/hotspot/gtest/oops/test_markOop.cpp
> +++ b/test/hotspot/gtest/oops/test_markOop.cpp
> @@ -36,6 +36,8 @@
>  #include "utilities/globalDefinitions.hpp"
>  #include "utilities/ostream.hpp"
>
> +// The test only works for ASSERT because it needs WizardMode
> +#ifdef ASSERT
>  static bool test_pattern(stringStream* st, const char* pattern) {
>    return (strstr(st->as_string(), pattern) != NULL);
>  }
> @@ -135,3 +137,4 @@
>    intx hash = h_obj->identity_hash();
>    assert_test_pattern(h_obj, "is_neutral hash=0x");
>  }
> +#endif // ASSERT
>
> so he's a reviewer too.
> Thanks,
> Coleen
>
> On 5/6/19 5:08 PM, coleen.phillimore at oracle.com wrote:
>> Thanks Per, also for the alert.
>> Coleen
>>
>> On 5/6/19 4:56 PM, Per Liden wrote:
>>> Looks good!
>>>
>>> /Per
>>>
>>> On 05/06/2019 10:48 PM, coleen.phillimore at oracle.com wrote:
>>>> Summary: disable the test in PRODUCT
>>>>
>>>> Tested locally with PRODUCT.  tier1 is in progress.  Sorry for the 
>>>> breakage.
>>>>
>>>> open webrev at 
>>>> http://cr.openjdk.java.net/~coleenp/2019/8223412.01/webrev
>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8223412
>>>>
>>>> Thanks,
>>>> Coleen
>>
>