RFR(T): 8223395: PPC64: Improve comments in the JVM signal handler to match ISA text

Gustavo Romero gromero at linux.vnet.ibm.com
Tue May 7 13:13:58 UTC 2019


Hi Goetz,

Thanks for the review!

The approval to push to jdk11u is ok now.

I've  prepared a webrev that applies cleanly to jdk11u (copyright hunk in the
original change is not necessary), if that helps:

http://cr.openjdk.java.net/~gromero/8223395/downport/

Could you sponsor the change, please?

Best regards,
Gustavo

On 05/07/2019 04:21 AM, Lindenmaier, Goetz wrote:
> Hi Gustavo,
> 
> Looks good, thanks!
> 
> Best regards,
>    Goetz.
> 
>> -----Original Message-----
>> From: hotspot-runtime-dev <hotspot-runtime-dev-bounces at openjdk.java.net>
>> On Behalf Of Gustavo Romero
>> Sent: Montag, 6. Mai 2019 16:39
>> To: Doerr, Martin <martin.doerr at sap.com>; hotspot-runtime-
>> dev at openjdk.java.net
>> Subject: Re: RFR(T): 8223395: PPC64: Improve comments in the JVM signal
>> handler to match ISA text
>>
>> Hi Martin,
>>
>> On 05/06/2019 11:30 AM, Doerr, Martin wrote:
>>> looks good and trivial. Thanks for improving the comments.
>>>
>>> Feel free to push with updated copyrights.
>>
>> Thanks for the review!
>>
>> Pushed with updated copyrights (sorry for missing the updates again on v1):
>>
>> http://hg.openjdk.java.net/jdk/jdk/rev/b39365cebb73
>>
>> Best regards,
>> Gustavo
> 


More information about the hotspot-runtime-dev mailing list