RFR: JDK-8223599: minimal build failed after JDK-8185525

[Aleksey Shipilev]

On 5/9/19 7:44 AM, David Holmes wrote:
> On 9/05/2019 3:25 pm, Wang Haomin wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223599
>> Webrev: http://cr.openjdk.java.net/~aoqi/8223599/webrev.00/
>>
>> Build is failed when using --with-jvm-features=-jfr. Would anyone review the fix?
> 
> I'm not sure this is the best way to fix this. I think JDK-8185525 needed to isolate
> TableRateStatistics more completely if it is only really used by JFR.
> 
> What you have will suffice for now, though you probably also want to guard:
> 
>  26 #include "jfr/jfr.hpp"
> 
> with "#if INCLUDE_JFR"

Yes, need to protect that.

Plus, need macros.hpp to gain access to INCLUDE_JFR without precompiled headers.

Plus, I think ifdef-ing the usages within the method bodies is cleaner, as it keeps method
declarations and definitions defined together.

Something like:

http://cr.openjdk.java.net/~shade/8223599/webrev.01/src/hotspot/share/utilities/tableStatistics.cpp.sdiff.html

-Aleksey