RFR (XS): 8222292: runtime/exceptionMsgs/ArrayIndexOutOfBoundsException/ArrayIndexOutOfBoundsExceptionTest.java timeout but test passed

[David Holmes]

Thanks Lois!

David

On 9/05/2019 9:24 pm, Lois Foltan wrote:
> Looks good David!
> Lois
> 
> On 5/9/2019 2:50 AM, David Holmes wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8222292
>> webrev: http://cr.openjdk.java.net/~dholmes/8222292/webrev/ (diff also 
>> below)
>>
>> The test is checking exception messages in three compilation modes 
>> using three @run directives:
>> - "normal" (start interpreted)
>> - C2 (via Xcomp 'no tiered')
>> - C1 (via Xcomp 'stop at level 1')
>>
>> when the test is run with Graal enabled it doesn't make sense to run 
>> these three variants (i.e. Graal in C1/C2 mode is nonsensical - you 
>> get Graal with some flags that affect how Graal runs). It also turns 
>> out the "C1-Graal" variant takes 20+ minutes to execute so the test 
>> times out.
>>
>> Simple fix: split the three tests into two distinct @test definitions. 
>> The first runs "normal" with or without Graal. The second runs C1/C2 
>> only when Graal is disabled. End result: we test four compiler 
>> variants, which is what we want. (Actually there is a fifth as we'll 
>> also test "normal" with Xcomp applied to it.)
>>
>> Thanks,
>> David
>> -----
>>
>> --- 
>> old/test/hotspot/jtreg/runtime/exceptionMsgs/ArrayIndexOutOfBoundsException/ArrayIndexOutOfBoundsExceptionTest.java 
>> 2019-05-09 02:34:49.740597326 -0400
>> +++ 
>> new/test/hotspot/jtreg/runtime/exceptionMsgs/ArrayIndexOutOfBoundsException/ArrayIndexOutOfBoundsExceptionTest.java 
>> 2019-05-09 02:34:49.267569730 -0400
>> @@ -26,8 +26,14 @@
>>   * @test
>>   * @summary Test extended ArrayIndexOutOfBoundsException message. The
>>   *   message lists information about the array and the indexes involved.
>> - * @compile ArrayIndexOutOfBoundsExceptionTest.java
>> + * @comment This will run in 'normal' mode when Graal is not enabled, 
>> else
>> + *   Graal mode.
>>   * @run testng ArrayIndexOutOfBoundsExceptionTest
>> + */
>> +/**
>> + * @test
>> + * @requires !vm.graal.enabled
>> + * @comment These test C1 and C2 so make no sense when Graal is enabled.
>>   * @run testng/othervm -Xcomp -XX:-TieredCompilation 
>> ArrayIndexOutOfBoundsExceptionTest
>>   * @run testng/othervm -Xcomp -XX:TieredStopAtLevel=1 
>> ArrayIndexOutOfBoundsExceptionTest
>>   */
>