RFR (S) 8223626: move print() functions to cpp files
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Thu May 9 14:47:03 UTC 2019
On 5/9/19 9:59 AM, David Holmes wrote:
> Hi Coleen,
>
> On 9/05/2019 11:10 pm, coleen.phillimore at oracle.com wrote:
>> Summary: improve debugging experience
>
> I have to ask, can't you just call print_on(tty) in the debugger?
Yes, I can call that, and often do after I try to call print() and get
the inlined message.
>
> But the change does as you say.
>
> One thing I spotted, in
> src/hotspot/share/classfile/classLoaderData.hpp you didn't make the
> change for print_value().
I missed one. Thanks.
Coleen
>
> Thanks,
> David
>
>> Ran mach5 hotspot tier1-3 tests.
>>
>> open webrev at
>> http://cr.openjdk.java.net/~coleenp/2019/8223626.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8223626
>>
>> Thanks,
>> Coleen
More information about the hotspot-runtime-dev
mailing list