RFR: JDK-8223599: minimal build failed after JDK-8185525
Aleksey Shipilev
shade at redhat.com
Thu May 9 16:56:09 UTC 2019
On 5/9/19 4:12 PM, Ao Qi wrote:
> On Thu, May 9, 2019 at 9:43 PM David Holmes <david.holmes at oracle.com> wrote:
>>
>> On 9/05/2019 9:12 pm, Wang Haomin wrote:
>>> Hi Aleksey, David,
>>>
>>> Thanks for your suggestion. However, build is failed when using
>>> "--with-jvm-features=-jfr --with-jvm-variants=server
>>> --with-debug-level=release --disable-precompiled-headers".
>>> I made a litter modification. Could you review it?
>>>
>>> Webrev: http://cr.openjdk.java.net/~aoqi/8223599/webrev.02/
>>
>> shenandoahCollectionSet.cpp was not altered by 8185525, so while I
>> understand your desire to make this fix, it doesn't seem right to do it
>> under the current bug as currently described. The issue with disabling
>> PCH would not seem to be related to the minimal build at all.
>
> Indeed. The initial desire is to fix the issue introduced by 8185525.
> Should I change the description or file another issue?
I'd say split it out. We would backport the Shenandoah issue.
-Aleksey
More information about the hotspot-runtime-dev
mailing list