RFR (S) 8223657: Remove unused THREAD argument from SymbolTable functions

[coleen.phillimore at oracle.com]

On 5/10/19 12:22 PM, gerard ziemski wrote:
> hi Coleen,
>
> Looks OK (though I wouldn't call it Small, Simple yes ;-)

Thanks Gerard for reviewing.

>
> One question: in src/hotspot/share/jvmci/compilerRuntime.cpp, did you 
> mean to remove the line:
>
>   48       TempNewSymbol sym = SymbolTable::new_symbol(name, len, CHECK);

Yes, I meant to remove it.  The code was turning a char* into a Symbol* 
in order to call StringTable::intern.  I don't see any reason for it 
doing this intermediate transformation.

Thanks!
Coleen

>
> ?
>
> Good cleanup.
>
>
> cheers
>
>
>
> On 5/10/19 10:15 AM, coleen.phillimore at oracle.com wrote:
>> Summary: also made lookup and lookup_only functions private to 
>> SymbolTable.  External callers use new_symbol or probe.
>>
>> Ran hs-tier1-3.
>>
>> open webrev at 
>> http://cr.openjdk.java.net/~coleenp/2019/8223657.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8223657
>>
>> Thanks,
>> Coleen
>