RFR (S) 8219459: oopDesc::is_valid() is broken

[Doerr, Martin]

Hi Coleen,

I'm fine with it.

Would you mind adding a comment that we currently only check both ends instead if the whole range is contained in one space?

Thank you for improving the lock.
I'd prefer braces around "VMError::is_error_reported() || Debugging".

I don't need to see another webrev.

Best regards,
Martin


-----Original Message-----
From: hotspot-runtime-dev <hotspot-runtime-dev-bounces at openjdk.java.net> On Behalf Of coleen.phillimore at oracle.com
Sent: Mittwoch, 8. Mai 2019 23:43
To: hotspot-runtime-dev at openjdk.java.net runtime <hotspot-runtime-dev at openjdk.java.net>
Subject: RFR (S) 8219459: oopDesc::is_valid() is broken

Summary: Use Metaspace::contains() to test address ranges.

Tested with hs-tier1-3, and all tier1 on linux-x64-debug.  Tested 
manually in gdb.

open webrev at http://cr.openjdk.java.net/~coleenp/2019/8219459.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8219459

Thanks,
Coleen