RFR(T): 8221738: ErrorFile option does not handle pre-existing error files of the same name

[Thomas Stüfe]

Thank you Christoph!

On Tue, May 14, 2019 at 9:17 AM Langer, Christoph <christoph.langer at sap.com>
wrote:

> Hi Thomas,
>
> this looks good to me.
>
> In the test, in method scanHsErrorFileForContent, you could use "br" in a
> try-with-resources block. Furthermore, there are a few whitespace issues -
> but hey, it's a test, so I'm ok with it ��
>
> Best regards
> Christoph
>
>
> > -----Original Message-----
> > From: hotspot-runtime-dev <hotspot-runtime-dev-
> > bounces at openjdk.java.net> On Behalf Of Thomas Stüfe
> > Sent: Sonntag, 7. April 2019 09:18
> > To: Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>
> > Subject: RFR(T): 8221738: ErrorFile option does not handle pre-existing
> error
> > files of the same name
> >
> > Hi all,
> >
> > May I please have reviews for this small fix:
> >
> > bug: https://bugs.openjdk.java.net/browse/JDK-8221738
> > cr:
> >
> http://cr.openjdk.java.net/~stuefe/webrevs/8221738-errorfile-option-does-
> > not-handle-pre-existing-error-files-of-the-same-name/webrev.00/webrev/
> >
> > Fixes a long standing issue where -XX:ErrorFile=<somename> will only work
> > if <somename> does not exist yet. If it does, error file falls silently
> > back to "<curdir>/hs_err_pid...".
> >
> > For more detailed discussions, please see the bug and the associated CSR.
> >
> > The fix now causes the error file to be overwritten
> >
> > Thanks, Thomas
>