RFR: jdk11u-dev backport: 8221470: Print methods in exception messages in java-like Syntax.

[Doerr, Martin]

Hi Götz,

thanks for fixing it. Backport looks good.
I think it's nice if jdk11 uses can get the better readable syntax, too. Maybe other reviewers have an opinion on this, too.

Best regards,
Martin


-----Original Message-----
From: hotspot-runtime-dev <hotspot-runtime-dev-bounces at openjdk.java.net> On Behalf Of Lindenmaier, Goetz
Sent: Freitag, 17. Mai 2019 16:00
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; jdk-updates-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net
Subject: [CAUTION] RE: RFR: jdk11u-dev backport: 8221470: Print methods in exception messages in java-like Syntax.

Hi, 

I'm sorry, I need to request another review. 
While linuxx86_64 opt build works fine, includes are missing
in some dbg builds, also the aix opt build failed.

I needed to add this:
--- a/src/hotspot/share/oops/symbol.cpp	
+++ b/src/hotspot/share/oops/symbol.cpp
@@ -34,6 +34,7 @@
 #include "oops/symbol.hpp"
 #include "runtime/atomic.hpp"
 #include "runtime/os.hpp"
+#include "runtime/signature.hpp"
 
 Symbol::Symbol(const u1* name, int length, int refcount) {
   _refcount = refcount;

New webrev:
http://cr.openjdk.java.net/~goetz/wr19/8221470-exMsg-signature-jdk11/02/

Best regards,
  Goetz.

> -----Original Message-----
> From: jdk-updates-dev <jdk-updates-dev-bounces at openjdk.java.net> On
> Behalf Of Lindenmaier, Goetz
> Sent: Dienstag, 14. Mai 2019 16:42
> To: jdk-updates-dev at openjdk.java.net; hotspot-runtime-
> dev at openjdk.java.net
> Subject: [CAUTION] RFR: jdk11u-dev backport: 8221470: Print methods in
> exception messages in java-like Syntax.
> 
> Hi,
> 
> I would like to backport this change.
> The hunk adding the new function in symbol.cpp
> does not apply because the context changed:
> Method try_increment_refcount() in the context is not
> there in jdk11.
> 
> Original jdk13 webrev & change
> http://cr.openjdk.java.net/~goetz/wr19/8221470-exMsg-signature/03/
> http://hg.openjdk.java.net/jdk/jdk/rev/532e88de77eb
> New jdk11u-dev webrev:
> http://cr.openjdk.java.net/~goetz/wr19/8221470-exMsg-signature-jdk11/01/
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8221470
> 
> Best regards,
>   Goetz.