RFR(XS): 8224165: [TESTBUG] Docker tests produce excessive output

Leonid Mesnik leonid.mesnik at oracle.com
Tue May 21 04:38:04 UTC 2019


Hi

Fix looks good. I have only one comment:
Does it make a sense to log all output for any docker command into separate file? The output might print name of this file additionally to MAX_LINES_TO_COPY_FOR_CHILD_STDOUT lines. It makes to investigate failures.

Leonid

> On May 20, 2019, at 9:14 PM, mikhailo.seledtsov at oracle.com wrote:
> 
> Please review this change that limits how much of child process output is copied into
> the main test output. Docker tests child processes produce too much output at times, which results in JT harness
> trimming the output, and can lead to loss of important diagnostic information.
> 
>     JBS: https://bugs.openjdk.java.net/browse/JDK-8224165
>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8224165.00/
>     Testing:
>        Ran HotSpot and JDK docker tests
>            test/hotspot/jtreg/containers/docker/
>            test/jdk/jdk/internal/platform/docker/
> 
>        No new failures
> 
> Thank you,
> Misha
> 



More information about the hotspot-runtime-dev mailing list