RFR(s): 8224193: stringStream should not use Resouce Area

[David Holmes]

Hi Thomas,

This all looks good to me too.

Thanks,
David

On 21/05/2019 4:03 pm, Thomas Stüfe wrote:
> Hi all,
> 
> second webrev, with Coleens remark worked in. I also added some comments
> and added a check to the test to test that stringStream backing buffer is
> always zero terminated.
> 
> Delta:
> http://cr.openjdk.java.net/~stuefe/webrevs/8224193-stringstream-shall-not-use-resource-array/webrev_delta.01/webrev
> Full:
> http://cr.openjdk.java.net/~stuefe/webrevs/8224193-stringstream-shall-not-use-resource-array/webrev.01/webrev/
> 
> Thank you, Thomas
> 
> On Mon, May 20, 2019 at 3:25 PM Thomas Stüfe <thomas.stuefe at gmail.com>
> wrote:
> 
>> Hi all,
>>
>> may I please have reviews for the following bug fix:
>>
>> issue: https://bugs.openjdk.java.net/browse/JDK-8224193
>> cr:
>> http://cr.openjdk.java.net/~stuefe/webrevs/8224193-stringstream-shall-not-use-resource-array/webrev.00/webrev/
>>
>> In short, stringStream uses resource area which is a poor choice -
>> depending on the logging we do, this may crash or assert and if it does not
>> it at least wastes memory.
>>
>> Note that I kept the change as simple as possible. There are other
>> possible improvements beside pure code cleanup, for which I opened follow
>> up issues https://bugs.openjdk.java.net/browse/JDK-8224212 and
>> https://bugs.openjdk.java.net/browse/JDK-8224213.
>>
>> Thanks, Thomas
>>
>>