RFR(M): 8220293: Deadlock in JFR string pool

[Markus Gronlund]

Thank you very much Robbin for taking a look.

Cheers
Markus

-----Original Message-----
From: Robbin Ehn 
Sent: den 21 maj 2019 15:49
To: Markus Gronlund <markus.gronlund at oracle.com>; Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>; hotspot-jfr-dev at openjdk.java.net
Subject: Re: RFR(M): 8220293: Deadlock in JFR string pool

Hi Markus,

On 2019-05-03 15:00, Markus Gronlund wrote:
> Greeting,
> 
> Please review the following patch to address the following:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8220293
> Webrev: http://cr.openjdk.java.net/~mgronlun/8220293/webrev01/
> 
> High level summary:
> 
> We don't want to release a retired buffer, because this will break the invariant that a successful acquisition implies a valid (non-retired) buffer.
> This is the reason why this work is, at least prima facie, a little more involved.

This seems fine, from my limited understanding of jfr buffer subsystem.

Thanks for fixing!

/Robbin

> 
> Tests:
> test case / reproducer attached to: https://bugs.openjdk.java.net/browse/JDK-8220293
> open/test/jdk/:jdk_jfr
> 
> Thank you
> Markus
>