RFR(S): 8224853: CDS address sanitizer errors

[Nick Gasson]

Hi Ioi,

On 31/05/2019 16:58, Ioi Lam wrote:
> Hi Nick,
> 
>   199 void java_lang_String::serialize_offsets(SerializeClosure* f) {
>   200   STRING_FIELDS_DO(FIELD_SERIALIZE_OFFSET);
>   201
>   202   // sizeof(bool) is implementation defined so ensure we pass a 
> pointer
>   203   // to an actual u4.
>   204   u4 tmp = initialized;
>   205   f->do_u4(&tmp);
> 
> This function can be called from ReadClosure in metaspaceShared.cpp to 
> update the value of "initialized".

Oh, thanks! I didn't realise it was bidirectional. It's strange I didn't 
see jtreg failures when I tested this.

> 
> I think it's better to add a new SerializeClosure::do_bool(bool*) 
> function, and implement it similar to {ReadClosure,WriteClosure}::do_u4().

I'll do this and updated the patch next week.

Thanks,
Nick