RFR(S): 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp

mikhailo.seledtsov at oracle.com mikhailo.seledtsov at oracle.com
Fri May 31 21:32:12 UTC 2019


Hi Harold,

   Thank you for Review.

On 5/31/19 1:59 PM, Harold Seigel wrote:
> Hi Misha,
>
> This change looks good!
>
> One small question, why change "dump-path" to "dump-path-" at line 66 
> of TestJcmdConfigure.java ?

Purely cosmetic change: the file name looks better this way: 
dump-path927834 vs dump-path-927834.


Misha

>
> Thanks, Harold
>
> On 5/31/2019 4:47 PM, mikhailo.seledtsov at oracle.com wrote:
>> Please review this change that converts all uses of 
>> Files.createTempFile/createTempDirecotry in JFR tests to
>> use corresponding test library Utils methods. Using test.lib.Utils 
>> for this purpose is a recommended practice
>> for JDK tests.
>>
>> I have also create a new method in jdk.test.lib.Utils: 
>> createTempDirectory()
>>
>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8223396
>>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8223396.00/
>>     Testing:
>>         1. Locally: ran the affected tests (Mac) - All PASS
>>         2. test cluster: running jdk_jfr and tier1 - in Progress
>>
>> Note: to be safe, I will not integrate this until Monday morning.
>>
>>
>> Thank you,
>> Misha
>>


More information about the hotspot-runtime-dev mailing list