RFR(S): 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp

[mikhailo.seledtsov at oracle.com]

Hi Leonid,

   Thank you for this suggestion.

No, I did not consider that. With my current fix I simply addressed the 
specific test set and a specific bug.

The change described in JDK-8213214 
<https://bugs.openjdk.java.net/browse/JDK-8213214> is much larger in 
scope and impact, touches build infra. The RFE is assigned to Erik, who 
is an expert in make and build system.


Best regards,

Misha

On 5/31/19 3:33 PM, Leonid Mesnik wrote:
> Hi
>
> Have you considered fixing makefiles to set 'java.io.tmpdir' described 
> the https://bugs.openjdk.java.net/browse/JDK-8213214
> rather than adding new method and fixing individual tests?
>
> Leonid
>> On May 31, 2019, at 1:47 PM, mikhailo.seledtsov at oracle.com 
>> <mailto:mikhailo.seledtsov at oracle.com> wrote:
>>
>> Please review this change that converts all uses of 
>> Files.createTempFile/createTempDirecotry in JFR tests to
>> use corresponding test library Utils methods. Using test.lib.Utils 
>> for this purpose is a recommended practice
>> for JDK tests.
>>
>> I have also create a new method in jdk.test.lib.Utils: 
>> createTempDirectory()
>>
>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8223396
>>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8223396.00/
>>     Testing:
>>         1. Locally: ran the affected tests (Mac) - All PASS
>>         2. test cluster: running jdk_jfr and tier1 - in Progress
>>
>> Note: to be safe, I will not integrate this until Monday morning.
>>
>>
>> Thank you,
>> Misha
>>
>