RFR(S): 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp

[Erik Joelsson]

Unfortunately, JDK-8213214 is blocked as some tests cannot handle how we 
would then set java.io.tmpdir.

In general, I think Misha's approach is much better. Jtreg is providing 
a scratch dir where tests can create files. There should be a very good 
reason to leaving droppings elsewhere. These files are also saved if 
anything goes wrong, which can aid debugging.

/Erik

On 2019-05-31 15:33, Leonid Mesnik wrote:
> Hi
>
> Have you considered fixing makefiles to set 'java.io.tmpdir' described 
> the https://bugs.openjdk.java.net/browse/JDK-8213214
> rather than adding new method and fixing individual tests?
>
> Leonid
>> On May 31, 2019, at 1:47 PM, mikhailo.seledtsov at oracle.com 
>> <mailto:mikhailo.seledtsov at oracle.com> wrote:
>>
>> Please review this change that converts all uses of 
>> Files.createTempFile/createTempDirecotry in JFR tests to
>> use corresponding test library Utils methods. Using test.lib.Utils 
>> for this purpose is a recommended practice
>> for JDK tests.
>>
>> I have also create a new method in jdk.test.lib.Utils: 
>> createTempDirectory()
>>
>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8223396
>>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8223396.00/
>>     Testing:
>>         1. Locally: ran the affected tests (Mac) - All PASS
>>         2. test cluster: running jdk_jfr and tier1 - in Progress
>>
>> Note: to be safe, I will not integrate this until Monday morning.
>>
>>
>> Thank you,
>> Misha
>>
>