RFR: 8233359: Add global sized operator delete definitions

David Holmes david.holmes at oracle.com
Fri Nov 1 05:07:38 UTC 2019


Hi Kim,

That looks fine and trivial IMO.

Thanks,
David

On 1/11/2019 11:15 am, Kim Barrett wrote:
> Please review this addition of replacement implementations for the
> global sized deallocation functions that were added by C++14.
> 
> Since Visual Studio 2017 or later always provides C++14 or later, we
> should be including these when using those compiler versions.
> 
> We also need these definitions when doing experimental C++14 builds
> with gcc (in preparation for JEP 347), to avoid -Wsized-deallocation
> warnings (enabled by the recent addition of -Wextra).
> 
> Rather than trying to determine whether the definitions are needed or
> not, we add them unconditionally. It's harmless to provide such
> definitions in non-product builds for pre-C++14 compilers; they just
> won't ever be called.
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8233359
> 
> Webrev:
> https://cr.openjdk.java.net/~kbarrett/8233359/open.00/
> 
> Testing:
> mach5 tier1
> 


More information about the hotspot-runtime-dev mailing list