RFR(T) 8233363: Clarify the DumpSharedSpaces condition in InstanceKlass::verify_on

[Calvin Cheung]

bug: https://bugs.openjdk.java.net/browse/JDK-8233363

Summary: change DumpSharedSpaces to Arguments::is_dumping_archive().

bash-4.2$ hg diff src/hotspot/share/oops/instanceKlass.cpp
diff --git a/src/hotspot/share/oops/instanceKlass.cpp 
b/src/hotspot/share/oops/instanceKlass.cpp
--- a/src/hotspot/share/oops/instanceKlass.cpp
+++ b/src/hotspot/share/oops/instanceKlass.cpp
@@ -3626,7 +3626,7 @@
      Array<int>* method_ordering = this->method_ordering();
      int length = method_ordering->length();
      if (JvmtiExport::can_maintain_original_method_order() ||
-        ((UseSharedSpaces || DumpSharedSpaces) && length != 0)) {
+        ((UseSharedSpaces || Arguments::is_dumping_archive()) && length 
!= 0)) {
        guarantee(length == methods()->length(), "invalid method 
ordering length");
        jlong sum = 0;
        for (int j = 0; j < length; j++) {

Ran CDS and AppCDS tests locally on linux-x64.

thanks,

Calvin