RFR(T): 8233530: gcc 5.4 build warning -Wc++14-compat after JDK-8233359

[Thomas Stüfe]

Hi David,

On Tue, Nov 5, 2019 at 8:19 AM David Holmes <david.holmes at oracle.com> wrote:

> Hi Thomas,
>
> On 5/11/2019 5:06 pm, Thomas Stüfe wrote:
> > Hi all,
> >
> > may I please have reviews for this small build fix:
> >
> > Issue: https://bugs.openjdk.java.net/browse/JDK-8233530
> > Webrev:
> >
> http://cr.openjdk.java.net/~stuefe/webrevs/8233530-wc14-compat/webrev.00/webrev/
> > Prior discussion:
> >
> https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2019-November/036726.html
>
> Seems fine in principle. :) This seems to be the first case of local
> warning suppression in the sources, so I didn't have anything to compare
> against.
>
>
This was Kim's explicit wish :) but I think it makes sense.


> I did find the use of
>
> #ifdef __GNUG__
>
> surprising as we don't use that define anywhere else in the sources. I'm
> guessing the 'G' refers to g++ and technically is more correct than using
>
> #ifdef __GNUC__
>
> but we always seem to use the latter even for C++. ??
>
>
Hmm.. I do not have strong emotions. I can use __GNUC__ if you prefer.

Thanks for looking!

..Thomas

Thanks,
> David
> -----
>
> > Thank you,
> >
> > Thomas
> >
>